-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Update test/others/test_utils.py
#5270
Conversation
Hey @bogdankostic, @silvanocerza and I were talking about these changes offline so he offered to review this PR |
Pull Request Test Coverage Report for Build 5462544132
💛 - Coveralls |
…test_match_context_single_process
Hey @silvanocerza before we merge, I'd like to double check with @tstadel that is okay for us to remove the dC tests or if it would be helpful to have them present until they can be moved (e.g. maybe into the new SDK). |
Ok for me even though I think it's not necessary. They weren't running and they will still be in the history if necessary. In any case I believe they must not be part of Haystack. |
I would highly recommend to keep tests (running) until the corresponding code has been removed. There is still functionality in the old SDK that is not yet part of the new SDK. Unless there is a good reason, we should stick to our usual deprecation process (for code and its corresponding tests). |
Related Issues
Proposed Changes:
Notes for the reviewer
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.