-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposal: Add RecentnessRanker
component
#5289
Conversation
Hey @elundaeva! I'll remove the proposal tag, as it has a different meaning and doesn't apply here 🙂 |
fe38fbf
to
cbb4a4e
Compare
Hey @ZanSara just to let you know, @elundaeva will be splitting this up into two separate PRs, one for the proposal and one for a draft PR of the code changes. |
6b412b4
to
9de3406
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @elundaeva, I think this would be a great addition to Haystack! Before approving this proposal, I would like the Detailed design
section to be more comprehensive.
4d7841c
to
63bb764
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the requested changes, @elundaeva! This looks good to me now!
According to our proposal process, the proposal needs the approval from three core contributors to move to the final comment phase. I'll share it with the rest of the core team :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thx @elundaeva...
RecentnessRanker
component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice to me but I have some critiques.
I think we should remove the links that point to private repos, the community won't be able to access them and that's a bum. We already have #5301 to show the code and that's fine.
I saw the relative PR mentions a paper in regards of the k
value used for the reciprocal rank fusion method, can we maybe link it here in the proposal?
Also would love if the PR description was formatted a bit more, deleting the template and briefly explaining the proposal would have been fine. 💙
420c0a6
to
5515546
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 🚀
Thank you everyone for the feedback, the proposal is now merged 🙂 💯 |
This proposal is for adding RecentnessRanker to Haystack. The ranker will allow to have retrieved documents sorted not only by relevance (default) but also with recency factored in. Here's the link to the code for this reranker: https://github.com/deepset-ai/haystack/pull/5301/files. The proposal contains an example pipeline setup with RecentnessRanker as well as some example use cases where sorting by recency can be important (e.g. when setting up QA on news content).