Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add job for ES8 integration tests #5297

Merged
merged 6 commits into from
Jul 10, 2023
Merged

Conversation

bogdankostic
Copy link
Contributor

Related Issues

Proposed Changes:

This PR renames the job integration-tests-elasticsearch to integration-tests-elasticsearch7 and lets it run using Elasticsearch 7.17.6 to test es7.ElasticsearchDocumentStore.

Furthermore, it adds the job integration-tests-elasticsearch8 which installs the installation extra elasticsearch8 and, therefore, uses es8.ElasticsearchDocumentStore for the integration tests using Elasticsearch 8.8.0.

How did you test it?

Notes for the reviewer

This PR depends on #5296.

Checklist

@bogdankostic bogdankostic marked this pull request as ready for review July 10, 2023 07:59
@bogdankostic bogdankostic requested a review from a team as a code owner July 10, 2023 07:59
@bogdankostic bogdankostic requested review from ZanSara and silvanocerza and removed request for a team and ZanSara July 10, 2023 07:59
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5505708540

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 44.789%

Totals Coverage Status
Change from base Build 5505551393: 0.0%
Covered Lines: 10328
Relevant Lines: 23059

💛 - Coveralls

This reverts commit ec12654.
@silvanocerza silvanocerza merged commit 048fc7f into main Jul 10, 2023
@silvanocerza silvanocerza deleted the es8_integration_test branch July 10, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants