Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate SklearnQueryClassifier #5324

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

anakin87
Copy link
Member

Related Issues

Proposed Changes:

Classic deprecation procedure for SklearnQueryClassifier

How did you test it?

New deprecation warning test

Checklist

@anakin87 anakin87 requested a review from a team as a code owner July 11, 2023 14:31
@anakin87 anakin87 requested review from julian-risch and removed request for a team July 11, 2023 14:31
@github-actions github-actions bot added topic:tests type:documentation Improvements on the docs labels Jul 11, 2023
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Now that the SklearnQueryClassifier is deprecated, we should also remove that node from the tutorial (and thereby fix deepset-ai/haystack-tutorials#220). To make the transition simpler for users, we could also publish trained versions of the default models of SklearnQueryClassifier on the HF model hub. That would allow users to easily switch from SklearnQueryClassifier to TransformersQueryClassifier. I'd say let's just keep that in mind in case we later see requests. For now, usage of SklearnQueryClassifier seems too low to justify the extra effort.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5521286276

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 17 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.04%) to 45.293%

Files with Coverage Reduction New Missed Lines %
utils/context_matching.py 1 91.67%
nodes/query_classifier/sklearn.py 16 43.55%
Totals Coverage Status
Change from base Build 5519435104: 0.04%
Covered Lines: 10445
Relevant Lines: 23061

💛 - Coveralls

@anakin87 anakin87 merged commit 6632505 into main Jul 11, 2023
@anakin87 anakin87 deleted the deprecate_SklearnQueryClassifier branch July 11, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:tests type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate SklearnQueryClassifier
3 participants