Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: HuggingFaceLocalGenerator - merge lazy import blocks #6358

Merged
merged 1 commit into from
Nov 21, 2023
Merged

fix: HuggingFaceLocalGenerator - merge lazy import blocks #6358

merged 1 commit into from
Nov 21, 2023

Conversation

anakin87
Copy link
Member

Related Issues

Proposed Changes:

  • Merge the lazy import blocks of transformers and torch
  • Make sure that the class StopWordsCriteria is contained in this block. It is required since it uses both transformers and torch.

How did you test it?

Manual test on a fresh venv

Checklist

@anakin87 anakin87 requested a review from a team as a code owner November 20, 2023 12:17
@anakin87 anakin87 requested review from vblagoje and removed request for a team November 20, 2023 12:17
@github-actions github-actions bot added 2.x Related to Haystack v2.0 type:documentation Improvements on the docs labels Nov 20, 2023
@anakin87 anakin87 added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Nov 20, 2023
vblagoje
vblagoje approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@vblagoje vblagoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice simplification!

@anakin87 anakin87 merged commit 1fff2bc into main Nov 21, 2023
21 of 22 checks passed
@anakin87 anakin87 deleted the fix-hf-localgen-torch-lazyimport branch November 21, 2023 10:15
vblagoje pushed a commit that referenced this pull request Nov 22, 2023
@anakin87 @vblagoje
merge lazy import blocks (#6358)
467b276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vblagoje vblagoje vblagoje approved these changes

Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes. type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Installation] Import of GPTGenerator failing without torch being installed
2 participants
@anakin87 @vblagoje