Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Rename model_name or model_name_or_path to model in all Embedder classes #6733

Merged
merged 21 commits into from
Jan 12, 2024
Merged

feat!: Rename model_name or model_name_or_path to model in all Embedder classes #6733

merged 21 commits into from
Jan 12, 2024

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Jan 12, 2024

Related Issues

Proposed Changes:

  • Rename model_name or model_name_or_path to model in all Embedder classes.

How did you test it?

Local tests run, CI

Notes for the reviewer

n/a

Checklist

@ZanSara ZanSara requested review from a team as code owners January 12, 2024 13:20
@ZanSara ZanSara requested review from dfokina and anakin87 and removed request for a team January 12, 2024 13:20
@github-actions github-actions bot added topic:tests 2.x Related to Haystack v2.0 type:documentation Improvements on the docs labels Jan 12, 2024
@ZanSara ZanSara mentioned this pull request Jan 12, 2024
Closed
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7503188691

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 87.169%
Totals Coverage Status
Change from base Build 7503171420: 0.04%
Covered Lines: 4280
Relevant Lines: 4910
💛 - Coveralls

anakin87
anakin87 approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good!

@ZanSara ZanSara merged commit 288ed15 into main Jan 12, 2024
25 checks passed
@ZanSara ZanSara deleted the rename-model-param-embedders branch January 12, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anakin87 anakin87 anakin87 approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 topic:tests type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZanSara @coveralls @anakin87