Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: bump transformers to 4.37.2 in test_requirements #6848

Merged
merged 2 commits into from
Jan 30, 2024
Merged

ci: bump transformers to 4.37.2 in test_requirements #6848

merged 2 commits into from
Jan 30, 2024

Conversation

anakin87
Copy link
Member

Related Issues

How did you test it?

CI; run an experiment with HF Local Generator on Colab (using Phi 2 model, a new addition to this release of Transformers)

Checklist

@github-actions github-actions bot added topic:tests 2.x Related to Haystack v2.0 labels Jan 29, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jan 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7708186181

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.78%
Totals Coverage Status
Change from base Build 7699233675: 0.0%
Covered Lines: 4510
Relevant Lines: 5080
💛 - Coveralls

@anakin87 anakin87 added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Jan 29, 2024
@anakin87 anakin87 changed the title ci: bump transformers to 4.37.1 in test_requirements ci: bump transformers to 4.37.2 in test_requirements Jan 29, 2024
@anakin87 anakin87 marked this pull request as ready for review January 30, 2024 08:18
@anakin87 anakin87 requested a review from a team as a code owner January 30, 2024 08:18
@anakin87 anakin87 requested review from vblagoje and removed request for a team January 30, 2024 08:18
@vblagoje
Copy link
Member

Wow, @anakin87 - this is the only place we need to now change for the transformer upgrade? Fantastic....

vblagoje
vblagoje approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@vblagoje vblagoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@anakin87 anakin87 merged commit 537107b into main Jan 30, 2024
30 checks passed
@anakin87 anakin87 deleted the bump-transformers-4-37-1-test-requirements branch January 30, 2024 16:19
@anakin87 anakin87 mentioned this pull request Jan 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vblagoje vblagoje vblagoje approved these changes

Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anakin87 @coveralls @vblagoje