-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: AnswerExactMatchEvaluator component inputs #7536
Conversation
Pull Request Test Coverage Report for Build 8658195269Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 👍 I just updated the docstring. It still referred to the old logic.
The release note looks great! We didn't include evaluation features in any earlier release. That's why I don't see a need to include the upgrade steps in the release notes of Haystack 2.1.0. In this particular case, it would be better to update this note instead: https://github.com/deepset-ai/haystack/blob/main/releasenotes/notes/exact-match-evaluator-197bb87b65e19d0c.yaml
@dfokina The draft of the documentation page is already up to date with the changes made in this PR. |
Related Issues
AnswerExactMatchEvaluator
input should be one answer per query instead of list of answers #7459Proposed Changes:
Change the component inputs as described in the attached issue
How did you test it?
Notes for the reviewer
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.