Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix broken serialization of HF API components #7661

Merged
merged 1 commit into from
May 8, 2024
Merged

fix: fix broken serialization of HF API components #7661

merged 1 commit into from
May 8, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented May 7, 2024

Related Issues

Proposed Changes:

In to_dict methods, replace the Enum with its string representation.

How did you test it?

CI, manual test.

Checklist

@anakin87 anakin87 requested review from a team as code owners May 7, 2024 13:10
@anakin87 anakin87 requested review from dfokina and julian-risch and removed request for a team May 7, 2024 13:10
@github-actions github-actions bot added topic:tests 2.x Related to Haystack v2.0 labels May 7, 2024
@anakin87 anakin87 changed the title fix: fix broken serialization of HFAPI components fix: fix broken serialization of HF API components May 7, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8986002285

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 90.374%
Totals Coverage Status
Change from base Build 8938725904: 0.04%
Covered Lines: 6516
Relevant Lines: 7210
💛 - Coveralls

@masci masci added this to the 2.1.1 milestone May 7, 2024
vblagoje
vblagoje approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@vblagoje vblagoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anakin87 anakin87 merged commit 7c9532b into main May 8, 2024
24 checks passed
@anakin87 anakin87 deleted the fix-hf-api-serialization branch May 8, 2024 15:14
silvanocerza pushed a commit that referenced this pull request May 9, 2024
@anakin87 @silvanocerza
fix broken serialization of HFAPI components (#7661)
6c4af2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vblagoje vblagoje vblagoje approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

@julian-risch julian-risch Awaiting requested review from julian-risch julian-risch is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 topic:tests
Projects
None yet
Milestone
2.1.1
Development

Successfully merging this pull request may close these issues.

(De-) Serialization is not properly working for HuggingFaceAPITextEmbedder
4 participants
@anakin87 @coveralls @vblagoje @masci