Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flag for use of window queries in SQLDocumentStore #768

Merged
merged 2 commits into from
Jan 25, 2021
Merged

Add flag for use of window queries in SQLDocumentStore #768

merged 2 commits into from
Jan 25, 2021

Conversation

tanaysoni
Copy link
Contributor

@tanaysoni tanaysoni commented Jan 25, 2021 •
edited
Loading

Resolves #758

@tanaysoni tanaysoni changed the title Add flag for enabling window queries in SQLDocumentStore WIP: Add flag for enabling window queries in SQLDocumentStore Jan 25, 2021
@tanaysoni tanaysoni changed the title WIP: Add flag for enabling window queries in SQLDocumentStore Add flag for use of window queries in SQLDocumentStore Jan 25, 2021
@tanaysoni tanaysoni requested a review from tholor January 25, 2021 11:52
tholor
tholor approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tanaysoni tanaysoni merged commit d9f011d into master Jan 25, 2021
@tanaysoni tanaysoni deleted the sqlite-fix branch January 25, 2021 11:54
@tanaysoni tanaysoni mentioned this pull request Jan 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholor tholor tholor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQLite OperationalError in SQLDocumentStore
2 participants
@tanaysoni @tholor