feat: allow DocumentJoiner to accept top_k parameter in run method #7709
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
The issue was caused by the
DocumentJoiner
component'srun
method not accepting thetop_k
parameter. This resulted in aValueError
when trying to passtop_k
at query time usingpipe.run("DocumentJoiner": {"top_k": top_k})
.To solve this issue, I updated the
run
method to accept thetop_k
parameter and use it to limit the number of returned documents. The relevant lines in therun
method were modified to check for thetop_k
parameter and apply it accordingly.How did you test it?
I added a unit test to the
test_document_joiner.py
file to ensure thetop_k
parameter works correctly when provided in therun
method. The test verifies that therun
method limits the number of returned documents to the specifiedtop_k
value.Notes for the reviewer
None
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.reno