feat: InMemoryDocumentStore serialization #7888
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
InMemoryDocumentStore
#7887Proposed Changes:
Added two
save_to_disk
andload_from_disk
functions.How did you test it?
Added a test
test_save_to_disk_and_load_from_disk
Notes for the reviewer
The test has an issue due to
cls.from_dict
methods somehow cachingInMemoryDocumentStore.values()
. I added an overwrite policy to avoid this but it is not the cleanest way. Not sure what is happening.Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.