Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add File Upload Functionality in UI #995

Merged
merged 5 commits into from
Apr 30, 2021
Merged

Add File Upload Functionality in UI #995

merged 5 commits into from
Apr 30, 2021

Conversation

bhadreshpsavani
Copy link
Contributor

@bhadreshpsavani bhadreshpsavani commented Apr 25, 2021

Proposed changes:

Status (please check what you already did):

  • First draft (up for discussions & feedback)
  • Final code
  • Added tests
  • Updated documentation

@Timoeller

@bhadreshpsavani
Copy link
Contributor Author

I have added a file upload button in UI in the left sidebar.
I created a function to use the backend file upload API.
I was getting below error, I am working on it
Screenshot from 2021-04-25 12-01-57
I think I need to convert the file into a specific format.

@oryx1729 oryx1729 self-requested a review April 28, 2021 14:14
@oryx1729
Copy link
Contributor

Hi @bhadreshpsavani, thank you for working on this PR! I'm happy to take over from here to resolve the issue and make it to the finish line.

@bhadreshpsavani
Copy link
Contributor Author

Hi @oryx1729,
Please go ahead and finish this!
I have limited experience working with UI integration!

@oryx1729 oryx1729 changed the title [WIP] Addition of File Upload Functionality in UI Add File Upload Functionality in UI Apr 30, 2021
@oryx1729 oryx1729 merged commit 37a72d2 into deepset-ai:master Apr 30, 2021
@Timoeller
Copy link
Contributor

Thanks for the valuable contribution @bhadreshpsavani cool to have you on board 👯

@bhadreshpsavani bhadreshpsavani deleted the file-upload-button branch May 1, 2021 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants