Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared exclusion tables #9

Merged
merged 6 commits into from
Mar 29, 2024
Merged

Shared exclusion tables #9

merged 6 commits into from
Mar 29, 2024

Conversation

deepsonshrestha
Copy link
Owner

@deepsonshrestha deepsonshrestha commented Mar 20, 2024

Describe your changes

This PR consists of compiling exclusion models into a common shared schema named shared_exclusions.

How has this been tested?

Newer shared exclusion logic has been tested against the production long table for NQF0059 measure and same number of exclusion flags have been reported.

Reviewer focus

Please focus on the implementation of shared_exclusions__exclude_frailty, shared_exclusions__exclude_advanced_illness and quality_measures__int_nqf0059_exclusions.

Checklist before requesting a review

  • I have updated the version number in dbt_project.yml file to reflect the release number of this PR
  • I have updated the docs files (by running dbt docs generate/serve and copying the necessary files into the docs folder)
  • I have commented my code as necessary
  • I have added at least one Github label to this PR
  • My code follows style guidelines
  • (Optional) I have recorded a Loom to explain this PR

(Optional) Gif of how this PR makes you feel

Loom link

@deepsonshrestha deepsonshrestha added the enhancement New feature or request label Mar 20, 2024
Copy link

@sarah-tuva sarah-tuva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Deepson, I was finally able to test this. I think it's working great! Let move forward with this solution.

Comment on lines 137 to 138
schema: |
{%- if var('tuva_schema_prefix',None) != None -%}{{var('tuva_schema_prefix')}}_shared_exclusions{% else %}shared_exclusions{%- endif -%}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we do the PR to the main repo, let's change the schema config back to quality_measures/_quality_measures to ensure all tables in this mart get created under the same schema/prefix.

@deepsonshrestha deepsonshrestha self-assigned this Mar 29, 2024
@deepsonshrestha deepsonshrestha merged commit d3054f8 into main Mar 29, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants