Use npm file: protocol to link @kustom/Samples dependency #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the
samples/run.sh
script, I hit a permission error becausenpm link
was trying to link into my global module location. Instead if thefile:
protocol is used in thepackage.json
, it will have the same effect linking the local dependency but avoid potential permission issues.With this change, all the tests are running and passing for me:
Thanks!