Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update default log level to info #637

Merged
merged 19 commits into from
Mar 20, 2024
Merged

chore: update default log level to info #637

merged 19 commits into from
Mar 20, 2024

Conversation

schaeferka
Copy link
Contributor

Description

Updated default LOG_LEVEL to info from debug.
...

Related Issue

Fixes #623

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@cmwylie19
Copy link
Collaborator

in monitor there is a console.debug call console.debug(\u001b[1;31m${filteredFailures}\u001b[0m), we may want to change that to console.log so that it does not go away

src/lib/assets/yaml.ts Outdated Show resolved Hide resolved
src/lib/assets/yaml.ts Outdated Show resolved Hide resolved
cmwylie19
cmwylie19 previously approved these changes Mar 13, 2024
Copy link
Collaborator

@cmwylie19 cmwylie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cmwylie19 cmwylie19 self-requested a review March 14, 2024 13:43
@schaeferka schaeferka marked this pull request as draft March 18, 2024 17:09
@schaeferka schaeferka marked this pull request as ready for review March 18, 2024 17:42
src/cli/dev.ts Outdated Show resolved Hide resolved
src/lib/controller/index.ts Outdated Show resolved Hide resolved
src/lib/controller/index.ts Outdated Show resolved Hide resolved
src/lib/controller/store.ts Outdated Show resolved Hide resolved
src/lib/controller/store.ts Outdated Show resolved Hide resolved
src/lib/controller/store.ts Outdated Show resolved Hide resolved
src/lib/controller/index.ts Outdated Show resolved Hide resolved
src/cli/dev.ts Outdated Show resolved Hide resolved
@cmwylie19 cmwylie19 merged commit af3d696 into main Mar 20, 2024
11 checks passed
@cmwylie19 cmwylie19 deleted the 623-log-level branch March 20, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

More documentation around LOG_LEVEL, set default to info
3 participants