-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use block.timestamp instead of block.number #63
Conversation
This should be a temporary change.
package.json
Outdated
@@ -38,7 +38,7 @@ | |||
"package.json": "sort-package-json" | |||
}, | |||
"dependencies": { | |||
"@defi-wonderland/prophet-core": "0.0.0-0954a47f", | |||
"@defi-wonderland/prophet-core": "github:defi-wonderland/prophet-core#de18a05", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait till defi-wonderland/prophet-core#46 is merged, release a new canary of the core package and use it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me, waiting for the core PR to be merged.
Co-authored-by: Gas <86567384+gas1cent@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🤖 Linear
Closes OPO-647
Tests pass using this version of prophet-core.