Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve focus handling when editing game.project #7613

Closed
vlaaad opened this issue Apr 27, 2023 · 0 comments · Fixed by #7614
Closed

Improve focus handling when editing game.project #7613

vlaaad opened this issue Apr 27, 2023 · 0 comments · Fixed by #7614
Assignees
@vlaaad
Labels
editor Issues related to the Defold editor task A task that needs to be performed

Comments

@vlaaad
Copy link
Contributor

vlaaad commented Apr 27, 2023

Task (REQUIRED):
We frequently lose focus on inputs after committing them, e.g. try changing Render's clear colors with tabbing.

Expected outcome (REQUIRED):
We shouldn't lose focus on committing the inputs in game.project
@vlaaad vlaaad added task A task that needs to be performed editor Issues related to the Defold editor labels Apr 27, 2023
@vlaaad vlaaad self-assigned this Apr 27, 2023
vlaaad added a commit that referenced this issue Apr 27, 2023
@vlaaad
Fix focus on committing values in the form view
e5e9905 
Technical notes:
When editing fields in the `game.project` it was possible to lose the input focus after committing the value if the value became clearable. This happened because a new node — reset button — was added to the grid pane children, and it caused the re-creation of this and subsequent inputs, so the view lost focus. Using `:fx/key` stabilized the component description -> JavaFX node mapping, enforcing that the input stays the same object and is not re-created.

User-facing changes:
We don't lose input focus when editing `game.project` fields.

Fixes #7613
@vlaaad vlaaad mentioned this issue Apr 27, 2023
Merged
vlaaad added a commit that referenced this issue Apr 27, 2023
@vlaaad
Fix focus on committing values in the form view (#7614)
a57710a 
Technical notes:
When editing fields in the `game.project` it was possible to lose the input focus after committing the value if the value became clearable. This happened because a new node — reset button — was added to the grid pane children, and it caused the re-creation of this and subsequent inputs, so the view lost focus. Using `:fx/key` stabilized the component description -> JavaFX node mapping, enforcing that the input stays the same object and is not re-created.

User-facing changes:
We don't lose input focus when editing `game.project` fields.

Fixes #7613
@vlaaad vlaaad closed this as completed Apr 27, 2023
@britzl britzl linked a pull request May 8, 2023 that will close this issue
Fix focus on committing values in the form view #7614
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vlaaad vlaaad

Labels
editor Issues related to the Defold editor task A task that needs to be performed
Projects
No open projects
1.4.6
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix focus on committing values in the form view defold/defold
1 participant
@vlaaad