Fix focus on committing values in the form view #7614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technical notes: When editing fields in the `game.project` it was possible to lose the input focus after committing the value if the value became clearable. This happened because a new node — reset button — was added to the grid pane children, and it caused the re-creation of this and subsequent inputs, so the view lost focus. Using `:fx/key` stabilized the component description -> JavaFX node mapping, enforcing that the input stays the same object and is not re-created. User-facing changes: We don't lose input focus when editing `game.project` fields. Fixes #7613
matgis
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical notes:
When editing fields in the
game.projectit was possible to lose the input focus after committing the value if the value became clearable. This happened because a new node — reset button — was added to the grid pane children, and it caused the re-creation of this and subsequent inputs, so the view lost focus. Using:fx/keystabilized the component description -> JavaFX node mapping, enforcing that the input stays the same object and is not re-created.User-facing changes:
We don't lose input focus when editing
game.projectfields.Fixes #7613