Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bob doesn't unpack plugin shared libraries unless they've changed #6472

Merged
merged 2 commits into from Mar 17, 2022
Merged

Bob doesn't unpack plugin shared libraries unless they've changed #6472

merged 2 commits into from Mar 17, 2022

Conversation

JCash
Copy link
Contributor

@JCash JCash commented Mar 15, 2022

No description provided.

@JCash JCash linked an issue Mar 15, 2022 that may be closed by this pull request
Avoid copying shared libraries if they haven't changed. #6471
Closed
@JCash
Copy link
Contributor Author

JCash commented Mar 15, 2022

Also helps this ticket:
defold/extension-spine#64

@JCash JCash requested a review from britzl March 15, 2022 16:11
britzl
britzl reviewed Mar 15, 2022
View reviewed changes
com.dynamo.cr/com.dynamo.cr.bob/src/com/dynamo/bob/pipeline/ExtenderUtil.java Outdated
return digest.digest();
}

private static boolean AreFilesIdentical(IResource src, File tgt) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

areFilesIdentical() with a lower a?

britzl
britzl requested changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@britzl britzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Feedback on the naming of function AreFilesIndentical.

@JCash JCash merged commit 46342fe into dev Mar 17, 2022
@JCash JCash deleted the issue-6471-bob-copy-plugins-fix branch March 17, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@britzl britzl britzl requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid copying shared libraries if they haven't changed.
2 participants
@JCash @britzl