Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase connection timeout during update #7254

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

britzl
Copy link
Contributor

@britzl britzl commented Jan 5, 2023

The editor update sometimes fails due to connection timeouts when the update is downloaded on a slow or low quality network. This change increases the connection timeout to 5000ms and the read timeout to 10000ms.

Fixes #7182

@britzl
Copy link
Contributor Author

britzl commented Jan 5, 2023

PR checklist

  • Code
    • Add engine and/or editor unit tests.
    • New and changed code follows the overall code style of existing code
    • Add comments where needed
  • Documentation
    • Make sure that API documentation is updated in code comments
    • Make sure that manuals are updated (in github.com/defold/doc)
  • Prepare pull request and affected issue for automatic release notes generator
    • Pull request - Write a message that explains what this pull request does. What was the problem? How was it solved? What are the changes to APIs or the new APIs introduced? This message will be used in the generated release notes. Make sure it is well written and understandable for a user of Defold.
    • Pull request - Link the pull request to the issue(s) it is closing. Use on of the approved closing keywords.
    • Affected issue - Assign the issue to a project
    • Affected issue - Assign the "breaking change" label to the issue if introducing a breaking change.
    • Affected issue - Assign the "skip release notes" is the issue should not be included in the generated release notes.

@britzl britzl requested a review from matgis January 5, 2023 09:17
Copy link
Contributor

@matgis matgis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@britzl britzl merged commit a3e0558 into editor-dev Jan 5, 2023
@britzl britzl deleted the DEFEDIT-7182-connection-timeout-during-update branch January 5, 2023 10:26
@britzl britzl linked an issue Jan 8, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade download failed. the progress was always 0
2 participants