Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to update euler or quaternion rotation before returning it to the user #7540

Merged
merged 1 commit into from Apr 5, 2023
Merged

Make sure to update euler or quaternion rotation before returning it to the user #7540

merged 1 commit into from Apr 5, 2023

Commits on Apr 3, 2023

  1. Check if euler has changed before returning value 

    Check if the euler angle has changed before returning a rotation or euler value in GetProperty.

When getting an euler angle:
If the euler angle hasn't changed we should update the euler angle with the value from the quaternion

When getting a quaternion:
If the euler angle has changed it is likely that we are getting the quaternion in a go.animate callback, in which case we should update the quaternion with the value of the euler angle
    @britzl
    britzl committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    f69a3ec View commit details
    Browse the repository at this point in the history