Don't add environment variables that are null to the ProcessExecutor #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCash
commented
Nov 28, 2022
Comment on lines
+186
to
+190
| String java_home = System.getenv("JAVA_HOME"); | ||
| if (java_home != null) | ||
| { | ||
| processExecutor.putEnv("JAVA_HOME", java_home); | ||
| } |
There was a problem hiding this comment.
We currently haven't setup the JAVA_HOME on the darwin server.
We'll need it for the Rive extension, since we are building jni stuff, and we need the java sdk (jni.h):
defold-rive/ext.manifest
includes: ["{{env.JAVA_HOME}}/include/linux", "{{env.JAVA_HOME}}/include"]
Comment on lines
+136
to
+139
| StringWriter sw = new StringWriter(); | ||
| PrintWriter pw = new PrintWriter(sw); | ||
| e.printStackTrace(pw); | ||
| throw new ExtenderException(sw.toString()); |
There was a problem hiding this comment.
This actually prints out the full callstack of the error.
I guess the cause, had another cause and we didn't iterate it?
britzl
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.