Added Android support when running a standalone server #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCash
requested changes
Jun 3, 2024
| @@ -1 +1 @@ | |||
| sdk.dir={{android-sdk-root}} | |||
| sdk.dir={{sdk-dir}} | |||
There was a problem hiding this comment.
The name of this file is a bit anonymous.
Perhaps add some "gradle" to the name?
Comment on lines
+13
to
+14
| export ANDROID_ROOT=${HOME}/android | ||
| export ANDROID_PROGUARD=${ANDROID_ROOT}/proguard.jar |
There was a problem hiding this comment.
I guess these variables should be in server/scripts/standalone/service-standalone.sh ?
| String contents = templateExecutor.execute(gradlePropertiesTemplateContents, envContext); | ||
| Files.write(gradlePropertiesFile.toPath(), contents.getBytes()); | ||
| } | ||
|
|
||
| private void createLocalPropertiesFile(File localPropertiesFile, Map<String, Object> jobEnvContext) throws IOException { | ||
| HashMap<String, Object> envContext = new HashMap<>(); | ||
| envContext.put("android-sdk-root", jobEnvContext.get("env.ANDROID_SDK_ROOT")); | ||
| envContext.put("sdk-dir", jobEnvContext.get("env.ANDROID_HOME")); |
There was a problem hiding this comment.
I'd rather have "android-home" instead?
Better for readability/discoverability imho.
|
@britzl May be it can be closed in favor of new splited version of Docker images? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.