Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cache issue #420

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Fix cache issue #420

merged 1 commit into from
Sep 4, 2024

Conversation

ekharkunov
Copy link
Contributor

Fix issue when one of precondition was failed during cache entry upload due to concurrency from the side of other jobs.

Caused by: com.google.api.client.http.HttpResponseException: 412 Precondition Failed 
PUT https://storage.googleapis.com/upload/storage/v1/b/************/o?ifGenerationMatch=*************
{ 
  "error": { 
    "code": 412, 
    "message": "At least one of the pre-conditions you specified did not hold.", 
    "errors": [ 
      { 
        "message": "At least one of the pre-conditions you specified did not hold.", 
        "domain": "global", 
        "reason": "conditionNotMet", 
        "locationType": "header", 
        "location": "If-Match" 
      } 
    ] 
  } 
} 

Now we catch and skip exception because it safe to continue because other job already uploaded the same cache entry.

@ekharkunov ekharkunov changed the base branch from dev to split-docker September 4, 2024 07:37
@ekharkunov ekharkunov merged commit e340a99 into split-docker Sep 4, 2024
@ekharkunov ekharkunov deleted the fix-cache-issue branch September 9, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants