DEF-3280 Fixed some null pointer accesses due to "malformed" manifest files #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathiaswking
commented
Aug 21, 2018
| private Map<String, Object> getManifestContext(ManifestConfiguration manifestConfig) throws ExtenderException { | ||
| ManifestPlatformConfig manifestPlatformConfig = manifestConfig.platforms.get(this.platform); | ||
| public static Map<String, Object> getManifestContext(String platform, Configuration config, ManifestConfiguration manifestConfig) throws ExtenderException { | ||
| ManifestPlatformConfig manifestPlatformConfig = manifestConfig.platforms.get(platform); |
There was a problem hiding this comment.
Made the function static for easier unit testing
mathiaswking
commented
Aug 21, 2018
| @@ -670,7 +670,7 @@ private File buildJavaExtension(File manifest, Map<String, Object> manifestConte | |||
| throw new ExtenderException(String.format("Extension %s contains invalid platform(s): %s. Allowed platforms: %s", manifestConfig.name, manifestPlatforms.toString(), allowedPlatforms.toString())); | |||
| } | |||
|
|
|||
| if (manifestPlatformConfig != null) { | |||
| if (manifestPlatformConfig != null && manifestPlatformConfig.context != null) { | |||
There was a problem hiding this comment.
An empty "context:" is the same as omitting it, so an empty HashMap() is now returned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.