Add autocomplete api #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
britzl
reviewed
Apr 7, 2021
britzl
reviewed
Apr 7, 2021
extension-admob/api/admob.script_api
Outdated
|
|
||
| - name: hide_banner | ||
| type: function | ||
| desc: Temporary hides Banner Ad, banner can be shown again using `admob.show_banner()` |
AGulev
approved these changes
Apr 7, 2021
extension-admob/api/admob.script_api
Outdated
| `admod.EVENT_EARNED_REWARD`, | ||
| `admod.EVENT_COMPLETE`, | ||
| `admod.EVENT_CLICKED`, | ||
| `admod.EVENT_DESTROYED`" |
There was a problem hiding this comment.
there is one more event in code EVENT_JSON_ERROR, that would be nice to add this even in doc and in example
There was a problem hiding this comment.
Probably 'internal' mark slightly confused me.. But I fully agree that event will be useful for user-specific logging and issues reporting.
extension-admob/api/admob.script_api
Outdated
| ```lua | ||
| function init(self) | ||
| if admob then | ||
| admob.set_callback(admob_callback) |
There was a problem hiding this comment.
it make sense to put init() function lower than admob_callback() in case if somebody copy/paste example and try to compile (we can't use function before we defined it)
There was a problem hiding this comment.
Oops, result of copypaste (was moved from initialization example). Fixed
britzl
approved these changes
Apr 7, 2021
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add autocomplete api for Defold Editor with native extension function/constants descriptions and links to AdMob original docs.
Disclaimer: my English is bad, it would be nice to proofread descriptions provided.
Also not sure about
admob.set_privacy_settings()parameter (seems to be ignored in Android impl) andadmob.EVENT_IMPRESSION_RECORDED(no cpp-side definition but present in ads.gui_script)