Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPGS Authorization and Saved games functionality using JNI #1

Merged
merged 35 commits into from
Jul 18, 2019
Merged

GPGS Authorization and Saved games functionality using JNI #1

merged 35 commits into from
Jul 18, 2019

Conversation

AGulev
Copy link
Contributor

@AGulev AGulev commented Jul 17, 2019

No description provided.

@AGulev
now it works commit
0af46f7
@AGulev
remove trash
949ec26
@AGulev
Init commit
30d6de8
@AGulev
First silent login implementation
fdf6557
@AGulev
new dependencies
0e6ac5b
@AGulev
Simple login example
17962a2
@AGulev
Logout added
61646fe
@AGulev
AppResult
d82e963
@AGulev
Login process
dfe160a
@AGulev
Show login popup
d42cfbb
@AGulev
Do not remove internal google play services
10df111
@AGulev
Get player data
3e2c65f
@AGulev
Added method set_popup_position
cd88531
@AGulev
Manifest merging tool
6b6a057
@AGulev
Remove old manifest
a9fe9a6
@AGulev
Added set_callback function
c40dc10
@AGulev
Added callback for events
f6b2dcd
@AGulev
Removed logs
6d53f8c
@AGulev
fix manifest
59bf673
@AGulev
New method showSavedGamesUI (snapshot feature init)
7c8fff8
@AGulev
Solved the conflicts
7a15651
@AGulev
Init Save
982e547
@AGulev
Send json instead single paremeters
9ea708b
@AGulev
Added new method getSave
c107d64
@AGulev
Added set_save method
b703502
@AGulev
Added new function save_and_close_snapshot
f71a702
@AGulev
Added methods is_authorized and is_snapshot_opened
ba3b1d9
@AGulev
Added methods get_max_snapshot_image_size and get_max_snapshot_size
da9dc96
@AGulev
typo fixed
22ad19e
@AGulev
cleanup resources
cdbb87c
jhonnyking
jhonnyking suggested changes Jul 18, 2019
View reviewed changes
Copy link

@jhonnyking jhonnyking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Mostly questions/comments and a few style changes.

.gitignore Outdated Show resolved Hide resolved
gpgs/ext.manifest Outdated Show resolved Hide resolved
gpgs/src/com_defold_gpgs_GpgsJNI.h Outdated Show resolved Hide resolved
gpgs/src/com_defold_gpgs_GpgsJNI.h Outdated Show resolved Hide resolved
gpgs/src/com_defold_gpgs_GpgsJNI.h Outdated Show resolved Hide resolved
gpgs/src/gpgs_extension.cpp Outdated Show resolved Hide resolved
gpgs/src/java/com/defold/gpgs/GpgsJNI.java Show resolved Hide resolved
gpgs/src/private_gpgs_callback.h Outdated Show resolved Hide resolved
gpgs/src/utils/LuaUtils.cpp Outdated Show resolved Hide resolved
gpgs/src/gpgs_jni.h Show resolved Hide resolved
@AGulev
Copy link
Contributor Author

AGulev commented Jul 18, 2019

@jhonnyking fixed. Thanks for the review!

@jhonnyking jhonnyking self-requested a review July 18, 2019 12:19
jhonnyking
jhonnyking approved these changes Jul 18, 2019
View reviewed changes
Copy link

@jhonnyking jhonnyking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AGulev AGulev merged commit bc55bca into master Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhonnyking jhonnyking jhonnyking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AGulev @jhonnyking