Handshake response object if handshake failed #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hsake stage, server's response can be reachable for further decisions
JCash
approved these changes
Feb 3, 2021
britzl
reviewed
Feb 3, 2021
| @@ -67,6 +67,19 @@ const char* StateToString(State err) | |||
|
|
|||
| #undef STRING_CASE | |||
|
|
|||
| int dmStriCmp(const char* s1, const char* s2) | |||
There was a problem hiding this comment.
We do have dmStrCaseCmp: https://defold.com/ref/stable/dmStringFunc/#dmStrCaseCmp:s1-s2
Could that be used instead?
There was a problem hiding this comment.
It could. We'll make a mental note of it and do that in another PR.
JCash
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added handshake response object, so if error occurs on websocket handshake stage, server's response can be reachable for further decisions