Issue 8: Handle the websocket close event #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCash
commented
Sep 27, 2020
| * `0` to disable debugging (i.e. no debug output). | ||
| * `1` to display state changes. | ||
| * `2` to display the messages sent and received. |
There was a problem hiding this comment.
Good to have for the users to be able to debug what's happening.
| @@ -20,10 +20,13 @@ local function websocket_callback(self, conn, data) | |||
| print("Connected " .. conn) | |||
| -- self.connection = conn | |||
| elseif data.event == websocket.EVENT_ERROR then | |||
| print("Error:", data.error) | |||
| print("Error:", data.message) | |||
There was a problem hiding this comment.
Api change: All events now have the "message".
| lua_setfield(L, -2, "message"); | ||
| } | ||
| lua_pushlstring(L, conn->m_Buffer + msg_offset, msg_length); | ||
| lua_setfield(L, -2, "message"); |
There was a problem hiding this comment.
Easier to reason about (and thus remember)
| @@ -94,7 +86,7 @@ ssize_t WSL_RecvCallback(wslay_event_context_ptr ctx, uint8_t *buf, size_t len, | |||
| dmSocket::Result socket_result = Receive(conn, buf, len, &r); | |||
|
|
|||
| if (dmSocket::RESULT_OK == socket_result && r == 0) | |||
| socket_result = dmSocket::RESULT_WOULDBLOCK; | |||
| socket_result = dmSocket::RESULT_CONNABORTED; | |||
There was a problem hiding this comment.
For some reason, when the server does an abnormal exit (1006), we don't get that message, and we'd just wait forever.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.