Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bob.jar plugins #3

Merged
merged 2 commits into from
May 10, 2023
Merged

Add bob.jar plugins #3

merged 2 commits into from
May 10, 2023

Conversation

AGulev
Copy link
Contributor

@AGulev AGulev commented May 10, 2023

I added it to alpha for now. Usually we need to catch it on early stage, later stages should be fine if alpha is fine

@AGulev AGulev requested a review from britzl May 10, 2023 09:36
@JCash
Copy link
Contributor

JCash commented May 10, 2023

"I added it to alpha for now. Usually we need to catch it on early stage, later stages should be fine if alpha is fine"

Same goes for the rest of the tests as well.

Note that this tests both the sdk, and the server.
I don't think we should keep certain tests to just one configuration.

@AGulev
Copy link
Contributor Author

AGulev commented May 10, 2023

"I added it to alpha for now. Usually we need to catch it on early stage, later stages should be fine if alpha is fine"

Same goes for the rest of the tests as well.

Note that this tests both the sdk, and the server. I don't think we should keep certain tests to just one configuration.

it makes sense, I added it to the other configs

@AGulev AGulev merged commit d4fe5cd into master May 10, 2023
@AGulev AGulev deleted the add-bob-plugin-tests branch May 10, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants