Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reusable workflow for common code #5

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

ekharkunov
Copy link
Contributor

@ekharkunov ekharkunov commented Jan 25, 2024

  • Add reusable workflow to avoid code duplication
  • Add arm64-macos platform to list of PLATFORMS
  • Add fail-fast: false to enable complete build of all extension. I guess it's better to collect all issues with extension compiling at once rather than fix and compile one-by-one.
  • Add dependabot configuration to follow github actions update
  • Update github actions version to eliminate warning about old nodejs runtime
  • Pin gh actions version (according to advise from https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions)

Example how it runs (without arm64-macos) https://github.com/ekharkunov/test-sdk/actions/runs/7651914447/job/20850637534

P.S. Warning about homoluctus/slatify is still presented. I'll fix it in separate PR.

Copy link
Contributor

@AGulev AGulev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
but it would be nice if @JCash take a look as well

@AGulev AGulev requested a review from JCash January 27, 2024 08:57
Comment on lines +11 to +12
test:
uses: ./.github/workflows/test.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

runs-on: ubuntu-latest
strategy:
fail-fast: false
max-parallel: 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to others: this is so we don't choke the server.

@JCash JCash merged commit 5f8f172 into defold:master Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants