-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors raised in promise callbacks should be logged to the console #59
Comments
If a callback fails and the catch handler runs, the Deferred is rejected Thanks, Brian On Sun, Oct 28, 2012 at 9:26 PM, rixo notifications@github.com wrote:
|
I am sorry, I don't know what an ER is. What does it mean? |
Enhancement Request. On Mon, Oct 29, 2012 at 7:58 AM, rixo notifications@github.com wrote:
|
Like a Pull Request? I have just submitted one : #60 Not sure that it will be useful to you though, I patched the JS but it seems that you develop Deft in CoffeeScript. |
I understand that the Promise/A spec requires that exceptions raised in callback do not halt execution. However, silenting them completely leads to a lot of confusion, especially before one realizes that Deft is catching all their JS errors.
Errors can be logged to the console without crashing the execution thread. For example, in Chrome:
will give the same output as an uncatched error, with the "correct" stack trace. I don't know for other browsers, but even if the full stack cannot be provided, a notice should definitely be issued.
The text was updated successfully, but these errors were encountered: