zuul fails on PRs

[feross]

Whenever a contributor sends a PR to one of my modules, the zuul tests fail because zuul can't find saucelab credentials. But it works just fine on master.

Sample failure:

> zuul -- test/basic.js
Error:
Zuul tried to run tests in saucelabs, however no saucelabs credentials were provided.
See the zuul wiki (https://github.com/defunctzombie/zuul/wiki/Cloud-testing) for info on how to setup cloud testing.
npm ERR! webtorrent@0.11.2 test-browser: `zuul -- test/basic.js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the webtorrent@0.11.2 test-browser script.
npm ERR! This is most likely a problem with the webtorrent package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     zuul -- test/basic.js
npm ERR! You can get their info via:
npm ERR!     npm owner ls webtorrent
npm ERR! There is likely additional logging output above.
npm ERR! System Linux 2.6.32-042stab090.5
npm ERR! command "/home/travis/.nvm/v0.10.33/bin/node" "/home/travis/.nvm/v0.10.33/bin/npm" "run" "test-browser"
npm ERR! cwd /home/travis/build/feross/webtorrent
npm ERR! node -v v0.10.33
npm ERR! npm -v 1.4.28
npm ERR! code ELIFECYCLE
npm ERR! 
npm ERR! Additional logging details can be found in:
npm ERR!     /home/travis/build/feross/webtorrent/npm-debug.log
npm ERR! not ok code 0
npm ERR! Test failed.  See above for more details.
npm ERR! not ok code 0
The command "npm test" exited with 1.

Full log: https://travis-ci.org/feross/webtorrent/builds/39314515

What's the cause?

[feross]

You can see that the sauce labs credentials do exist: https://github.com/feross/webtorrent/blob/master/.travis.yml

[defunctzombie]

It is because the contributor is not allowed to run things with encrypted env vars. This is so that they can't just dump your credentials by just making a PR that does console.log in the tests once the env var is loaded. I don't really know a good way around this. It is a travis "feature" and not specific to zuul.

[feross]

Hm, the credentials to my free sauce labs account aren't super important. Wish I could just risk it. It's way worse not having test feedback in PRs... Silly feature.

[defunctzombie]

You could just put them in as regular env vars vs encrypted vars.
On Oct 29, 2014 2:04 AM, "Feross Aboukhadijeh" notifications@github.com
wrote:

Hm, the credentials to my free sauce labs account aren't super important.
Wish I could just risk it. It's way worse not having test feedback in
PRs... Silly feature.

—
Reply to this email directly or view it on GitHub
#86 (comment).

[feross]

Thanks for the help on this, btw :)

[guoyouess]

zuul --local