Add custom events to replace ajax callbacks #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds pjax:beforeSend, pjax:complete, pjax:error, and pjax:success
This was referenced Feb 21, 2012
|
@defunkt Do these deprecation changes seem reasonable? |
|
Yeah, this looks good. Maybe |
josh
added a commit
that referenced
this pull request
Feb 22, 2012
Add custom events to replace ajax callbacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ajax callbacks can't be persisted into the browser history, we should prefer custom events instead.
This adds events for
pjax:beforeSend,pjax:complete,pjax:errorandpjax:success.