Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: calling Resolve() on a di.Injectable would overwrite the skip fields #35

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

chirino
Copy link
Contributor

@chirino chirino commented Jun 15, 2021

fix: calling Resolve() on a di.Injectable would overwrite the skip fields

@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #35 (3930f48) into master (02504b0) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   93.86%   93.91%   +0.04%     
==========================================
  Files          16       16              
  Lines         522      526       +4     
==========================================
+ Hits          490      494       +4     
  Misses         21       21              
  Partials       11       11              
Impacted Files Coverage Δ
container.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02504b0...3930f48. Read the comment docs.

@defval defval merged commit d16365e into defval:master Jun 16, 2021
@chirino chirino deleted the fix-resolve-injectable branch June 17, 2021 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants