fix: prefer using "di:" field tags to control injection options to avoid conflicting with tags used by other libraries. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conflicting with tags used by other libraries. old style is still supported but generates a deprecation warning like: ``` 2021/07/16 13:40:19 Deprecation warning: please replace the field tags on 'Server.Tags' with: di:"http=true,server=true" ```
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
=======================================
Coverage 95.06% 95.06%
=======================================
Files 16 16
Lines 689 730 +41
=======================================
+ Hits 655 694 +39
- Misses 23 24 +1
- Partials 11 12 +1
Continue to review full report at Codecov.
|
|
Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: prefer using "di:" field tags to control injection options to avoid conflicting with tags used by other libraries.
old style is still supported but generates a deprecation warning like:
this fixes #37