fix: you could not use a struct to for both di and json marshalling.

[chirino]

You must at least add an empty di:"" tag to struct fields to also support json marshalling. Added test case to verify it works.

[codecov]

Codecov Report

Merging #41 (4a262a6) into master (3325231) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   95.06%   95.08%   +0.01%     
==========================================
  Files          16       16              
  Lines         730      732       +2     
==========================================
+ Hits          694      696       +2     
  Misses         24       24              
  Partials       12       12              

Impacted Files	Coverage Δ
inject.go	88.33% <100.00%> (+0.19%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3325231...4a262a6. Read the comment docs.

[defval]

Hi, @chirino! This change breaks backward compatibility. And some time ago we already refused empty "di" tags. Because we didn't think that program components could be serialized.

Maybe you should separate the data structures containing dependencies and configuration?

[chirino]

Do you have any examples of how this might break existing apps? Seems to me if it empty tags were previously not allowed, then there should be no previous apps that are using empty di tag.

[defval]

They've been there before.

Sorry. I remembered that you were doing support for the old syntax. And our internal cases are exactly covered with tests.

We can merge it.

[defval]

Released in https://github.com/goava/di/releases/tag/v1.11.1