-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profiles #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Resonious please review this |
Resonious
approved these changes
Jan 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't see anything unexpected in the code and the feature seems to work 👍
return error_result(saveError.Error()) | ||
} | ||
|
||
newProfile, err3 := oper.getProfile() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
err3
lol gotta love Go
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
profiles
command to bcn cli.How to test
There's a bunch of things to do here.
First rename
~/.bcn
to something else, or copy it somewhere to back it up.Create
rm -rf ~/.bcn
./bcn profile create titan
open /Users/davidsiaw/.bcn/id_ecdsa: no such file or directory
Restore your original
~/.bcn
./bcn profile create titan
./bcn profile show
returnstitan
~/.bcn/login
file's URL to be something else liketitan.com
./bcn profile use default
./bcn profile show
returnsdefault
and the original URL./bcn profile use titan
again./bcn profile show
returnstitan
and shows your modified URL