Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiles #46

Merged
merged 9 commits into from
Jan 7, 2021
Merged

Profiles #46

merged 9 commits into from
Jan 7, 2021

Conversation

davidsiaw
Copy link
Contributor

@davidsiaw davidsiaw commented Dec 17, 2020

This PR adds a new profiles command to bcn cli.

How to test

There's a bunch of things to do here.

First rename ~/.bcn to something else, or copy it somewhere to back it up.

Create

  1. Delete rm -rf ~/.bcn
  2. Run ./bcn profile create titan
  3. Should show you something like open /Users/davidsiaw/.bcn/id_ecdsa: no such file or directory

Restore your original ~/.bcn

  1. Run ./bcn profile create titan
  2. Check that ./bcn profile show returns titan
  3. Modify the ~/.bcn/login file's URL to be something else like titan.com
  4. ./bcn profile use default
  5. Check that ./bcn profile show returns default and the original URL
  6. ./bcn profile use titan again
  7. Check that ./bcn profile show returns titan and shows your modified URL

@davidsiaw davidsiaw marked this pull request as ready for review January 6, 2021 10:25
@degicat degicat requested a review from Resonious January 6, 2021 10:25
@degicat
Copy link

degicat commented Jan 6, 2021

@Resonious please review this

Copy link
Member

@Resonious Resonious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't see anything unexpected in the code and the feature seems to work 👍

return error_result(saveError.Error())
}

newProfile, err3 := oper.getProfile()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

err3 lol gotta love Go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants