update python #813
Open
update python #813
+8
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@showwin can you help us review this PR, please? |
showwin
approved these changes
Jul 23, 2024
| ENV GOPATH /.go | ||
| ENV GOBIN $GOPATH/bin | ||
| ENV PATH=$GOBIN:$PATH | ||
| FROM alpine |
There was a problem hiding this comment.
Should we pin the version to prevent it from being updated to 4.0 without us noticing?
Suggested change
| FROM alpine | |
| FROM alpine:3.20 |
There was a problem hiding this comment.
i pinned it once but i think its better to just keep it up to date.
There was a problem hiding this comment.
It's better to keep it up to date explicitly by creating PR. If we have many places that update versions automatically, it's hard to identify which new library version introduce a problem. (We will need to visit every release page to check the latest release or compare installed versions using old and new environments.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dependencies python for AWS lambda and remove glide and replace it with go modules