Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase build list limit from default (5) to 20 #8

Merged
merged 2 commits into from
Apr 5, 2017
Merged

Conversation

k2nr
Copy link
Member

@k2nr k2nr commented Apr 5, 2017

The default limit of the list builds API is 5. We had an issue where we restarted a travis build which initially ran 1 day ago and bcnd couldn't find the build for the git SHA that the travis build was building because since the travis build was created, more than 5 builds were created in quay. I think 20 is enough limit but if we have the same problem with limit 20, I'll increase the limit number again

@degicat
Copy link

degicat commented Apr 5, 2017

@degicat Please review this.

2 similar comments
@degicat
Copy link

degicat commented Apr 5, 2017

@degicat Please review this.

@degicat
Copy link

degicat commented Apr 5, 2017

@degicat Please review this.

@degicat
Copy link

degicat commented Apr 5, 2017

@shioyama Please review this.

@shioyama
Copy link

shioyama commented Apr 5, 2017

LGTM 👍

@k2nr
Copy link
Member Author

k2nr commented Apr 5, 2017

Thanks! I'll merge and release a new version

@k2nr k2nr merged commit 3f0f8e9 into master Apr 5, 2017
@k2nr k2nr deleted the limit-20 branch April 5, 2017 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants