Pull request for Week 3 #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onyekaugochukwu
commented
Sep 5, 2022
onyekaugochukwu
commented
- All unit tests passed.
- I created a new branch as suggested
Commit suggestions from Rebecca Sanjabi Co-authored-by: Rebecca Sanjabi <47192430+rsanjabi@users.noreply.github.com>
Updated the Schedules, Sensors and Partitions required for Week 3
czroth
reviewed
Sep 5, 2022
Comment on lines
+59
to
+61
| stock_high_list = [stock.high for stock in stocks] | ||
| highest_stock = float(heapq.nlargest(1,stock_high_list)[0]) | ||
| highest_date = stocks[stock_high_list.index(highest_stock)].date |
There was a problem hiding this comment.
You can use the builtin max function and define the key which simplifies this code considerably and removes the heapq dependency.
czroth
reviewed
Sep 5, 2022
Comment on lines
+39
to
+41
| stock_high_list = [stock.high for stock in stocks] | ||
| highest_stock = float(heapq.nlargest(1,stock_high_list)[0]) | ||
| highest_date = stocks[stock_high_list.index(highest_stock)].date |
There was a problem hiding this comment.
See the comment in week1.py
Sorry, I didn't put that comment here.
Comment on lines
+90
to
+108
| return { | ||
| "resources": { | ||
| "s3": { | ||
| "config": { | ||
| "bucket": "dagster", | ||
| "access_key": "test", | ||
| "secret_key": "test", | ||
| "endpoint_url": "http://host.docker.internal:4566", | ||
| } | ||
| }, | ||
| "redis": { | ||
| "config": { | ||
| "host": "redis", | ||
| "port": 6379, | ||
| } | ||
| }, | ||
| }, | ||
| "ops": {"get_s3_data": {"config": {"s3_key": "prefix/stock_{}.csv".format(partition_key)}}}, | ||
| } |
There was a problem hiding this comment.
This and the following dictionary are essentially the same at the one on lines 67-84. Consider using the docker dict as a starting place and updating just the ops key to avoid duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.