Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to reduce the complexity & number of API calls to controller on each git push #144

Open
arschles opened this issue Feb 4, 2016 · 3 comments

Comments

@arschles
Copy link
Member

arschles commented Feb 4, 2016

As of this writing, we make 3 calls. After #122, it may be 4. If we can batch, pipeline, or use a different wire protocol (that option would probably require the most changes by far), we should.

@arschles arschles changed the title try to reduce the number of API calls to controller on each git push try to reduce the complexity & number of API calls to controller on each git push Feb 4, 2016
@arschles
Copy link
Member Author

arschles commented Feb 4, 2016

One optimization after #122 is done is to have builder keep a cache of SSH keys on-disk and only request key change deltas since a last version.

@smothiki
Copy link
Contributor

smothiki commented Feb 4, 2016

This is what I feel git push and updating keys have to happen asynchronously. keys:add is a complete different operations as git push is . Keys add has already happened by the time we do git push .

@arschles
Copy link
Member Author

arschles commented Feb 4, 2016

@smothiki they can still happen asynchronously (see the reaper discussion above), but we need to have the synchronous call so that the keys:add operation is strongly consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants