Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor the makefile #25

Closed
arschles opened this issue Dec 10, 2015 · 1 comment
Closed

refactor the makefile #25

arschles opened this issue Dec 10, 2015 · 1 comment

Comments

@arschles
Copy link
Member

it's gotten very large, and is responsible for a few different tasks:

  1. building the project, dockerizing, deploying to k8s
    • requires a second target to build the minio binary from master on https://github.com/minio/minio. that target may go away when the minio server becomes stable
  2. building the mc binary from master on https://github.com/minio/mc, dockerizing a second image and deploying that to k8s. The build step may go away when the mc client becomes stable
  3. build the mc integration tests, dockerizing a third image, and deploying that to k8s

It may make sense to split the integration tests in (3) into a separate repository. Regardless, the makefile is hard to follow.

Targets should be grouped together, and have a comment for each group, and each target should also be commented.

Also, an overview of the high level targets and workflows should be on the README.

Finally, dependencies don't make a ton of sense right now. Some ideas:

  • docker-push could depend on docker-build but it isn't now
  • does it make sense for docker-build to depend on build-server and build at once?
@arschles
Copy link
Member Author

Fixed by #47, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant