Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for affinityArg #88

Closed
krancour opened this issue Jan 13, 2016 · 2 comments
Closed

Add support for affinityArg #88

krancour opened this issue Jan 13, 2016 · 2 comments
Assignees
@krancour
Milestone
v2.0-beta1

Comments

@krancour
Copy link
Contributor

v1.x supported this. v2 should as well.
@krancour krancour self-assigned this Jan 13, 2016
@krancour krancour added this to the v2.0-beta1 milestone Jan 13, 2016
@krancour
Copy link
Contributor Author

Actually, I don't think this makes sense anymore. It did in v1.x where we explicitly managed multiple upstreams for each app. But in v2, the router(s) sit in front of k8s services and k8s services offer two choices for session affinity: none or client-IP based. The client-IP based affinity might work behind the router (I haven't tried), but it would be achieved by modifying the service, not by modifying router configuration.

IMO, this issue should just be dropped. Ping @slack and @technosophos for opinions.

@krancour
Copy link
Contributor Author

Closing this. It can be re-opened later if anyone feels it is truly an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krancour krancour

Labels
None yet
Projects
None yet
Milestone
v2.0-beta1
Development

No branches or pull requests
1 participant
@krancour