-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make test code print an informational error message if it doesn't find 'DEIS_CONTROLLER_URL' in the environment #163
Comments
cc/ @krancour |
In this case, you shouldn't have to worry about the value of
The Makefile already offers this explanation if
I would suggest that the only real problem we have on this front is that if someone executes |
As far as I can tell, the remaining work in here is to transplant the makefile logic to translate some Makefile logic into tests themselves. |
Punting to beta4 |
@krancour does it make sense to leave this open? Regardless, moving to RC1 |
This issue was moved to teamhephy/workflow-e2e#13 |
After #157, the tests look for
DEIS_CONTROLLER_URL
in the environment to determine what server to talk to in order to run tests. This variable can be set to a variety of different values, and the test should explain the options:DEIS_CONTROLLER_URL=${DEIS_ROUTER_SERVICE_HOST}:${DEIS_ROUTER_SERVICE_PORT}
DEIS_CONTROLLER_URL=deis.${EXTERNAL_ROUTER_IP}.xip.io
(or you can use.nip.io
, or your own domain if you've configured one...)The text was updated successfully, but these errors were encountered: