Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment var to specify AWS Athena workgroup #102

Merged
merged 2 commits into from
May 10, 2023

Conversation

seanlane
Copy link
Contributor

@seanlane seanlane commented May 9, 2023

resolves #99

Adds an environment variable DEKART_ATHENA_WORKGROUP, and then attempts to use that value for specifying the Athena workgroup used when starting a query execution. If the value is not set or is empty, the default value will be a nil string pointer.

When the WorkGroup field of the StartQueryExecutionInput struct is a nil pointer, Athena uses the primary workgroup that exists within all AWS accounts (since the primary workgroup cannot be renamed or deleted, per AWS documentation here).

This is the current, implicit behavior since WorkGroup was not being utilized until now. If the value is not set, a warning will be emitted when an Athena query is executed, for example:

Screen Shot 2023-05-09 at 10 40 54 AM

If the specified workgroup does not exist, the query will fail, but I consider that to be expected behavior.

When the environment variable is set, a debug message is emitted when an Athena query, for example:

Screen Shot 2023-05-09 at 10 40 20 AM

@seanlane seanlane requested a review from a team as a code owner May 9, 2023 16:54
seanlane added a commit to seanlane/dekart-www that referenced this pull request May 9, 2023
Add documentation for the environment variable `DEKART_ATHENA_WORKGROUP` that will be will the following Dekart PR: dekart-xyz/dekart#102
@delfrrr
Copy link
Contributor

delfrrr commented May 10, 2023

Great, appreciate!

@delfrrr delfrrr merged commit e3eb948 into dekart-xyz:main May 10, 2023
4 checks passed
@delfrrr
Copy link
Contributor

delfrrr commented May 10, 2023

@seanlane feature available in v0.12.2-rc.1

@delfrrr
Copy link
Contributor

delfrrr commented May 15, 2023

Hey, @seanlane, join our Slack, will be happy chatting with you and having your feedback!

@seanlane
Copy link
Contributor Author

will do, thanks for the invite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Specify Athena workgroup as an environment variable
2 participants