Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Register hooks when session is closing(). #112

Merged
merged 1 commit into from
Feb 6, 2019

Conversation

iocanel
Copy link
Member

@iocanel iocanel commented Feb 6, 2019

My recent refactoring completely broke all hooks. This is a fix for it.

@iocanel iocanel requested a review from geoand February 6, 2019 14:10
@geoand
Copy link
Collaborator

geoand commented Feb 6, 2019

Is there a chance that we could have tests that would catch such breaks in the future?

@iocanel
Copy link
Member Author

iocanel commented Feb 6, 2019

Good question!

In theory we could use the maven-invoker-plugin apprach in order to have mvn clean install -Dap4k.deploy=true and then check if that worked. But there are a couple of tricky details we need to take care.

I'd say lets create an issue and have this merged for now.

@geoand
Copy link
Collaborator

geoand commented Feb 6, 2019

Good question!

In theory we could use the maven-invoker-plugin apprach in order to have mvn clean install -Dap4k.deploy=true and then check if that worked. But there are a couple of tricky details we need to take care.

I'd say lets create an issue and have this merged for now.

Makes sense!

Copy link
Collaborator

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@iocanel iocanel merged commit d51e5a6 into dekorateio:master Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants