Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect login not notified #22

Closed
djasnowski opened this issue Feb 26, 2018 · 1 comment
Closed

Incorrect login not notified #22

djasnowski opened this issue Feb 26, 2018 · 1 comment
Assignees
@djasnowski
Labels
backend Node.js-related or anything to do in the server database MySQL or SQL related issues on the game. easy Issue/feature that is easy to fix or implement. Good for 1st-time contributors. enhancement When functionality needs to be changed or updated. good first issue Easy issues that are excellent for people wanting to get in meat of the code. medium priority It would be awesome if this was done, but not very critical. player Features/issues relating to the player of Delaford. web socket WebSocket issues and discussion.
Milestone
v0.1.0

Comments

@djasnowski
Copy link
Member

Do you want to request a feature or report a bug?

bug

What is the current behavior?

When a user attempts to login with invalid username/password -- nothing happens. In the backend, however, a 401 request is returned (unauthenticated.)

If the current behavior is a bug, please provide the exact steps to reproduce.

  1. Login with invalid credentials at login screen

What is the expected behavior?

A message or modal of some kind should appear letting the user know of their attempt
@djasnowski djasnowski added enhancement When functionality needs to be changed or updated. good first issue Easy issues that are excellent for people wanting to get in meat of the code. player Features/issues relating to the player of Delaford. easy Issue/feature that is easy to fix or implement. Good for 1st-time contributors. medium priority It would be awesome if this was done, but not very critical. backend Node.js-related or anything to do in the server database MySQL or SQL related issues on the game. web socket WebSocket issues and discussion. labels Feb 26, 2018
@djasnowski djasnowski added this to the v0.0.1 milestone Feb 26, 2018
@djasnowski
Copy link
Member Author

screen shot 2018-09-09 at 7 54 04 pm

@djasnowski djasnowski self-assigned this Sep 10, 2018
djasnowski pushed a commit that referenced this issue Sep 13, 2018
Closes #22 - incorrect login.
62d4bc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djasnowski djasnowski

Labels
backend Node.js-related or anything to do in the server database MySQL or SQL related issues on the game. easy Issue/feature that is easy to fix or implement. Good for 1st-time contributors. enhancement When functionality needs to be changed or updated. good first issue Easy issues that are excellent for people wanting to get in meat of the code. medium priority It would be awesome if this was done, but not very critical. player Features/issues relating to the player of Delaford. web socket WebSocket issues and discussion.
Projects
None yet
Milestone
v0.1.0
Development

No branches or pull requests
1 participant
@djasnowski