Quote port "21:21" throughout, add note about base-60, add compose example #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd compose example When mapping ports in the HOST:CONTAINER format, you may experience erroneous results when using a container port lower than 60, because YAML parses numbers in the format xx:yy as a base-60 value. For this reason, it is recommended to always explicitly specify low-number port mappings as strings. Port 21 is impacted by this, and quoting the port ensures that, should someone translate this to a docker-compose file, this behaviour won't arise. As such, the 21:21 is quoted in the various examples in the readme file. Moreover, I have translated the first usage example into a compose file and placed a note there as well.
|
@michaelkrieger thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #29 , when mapping ports in the HOST:CONTAINER format, you may experience erroneous results when using a container port lower than 60, because YAML parses numbers in the format xx:yy as a base-60 value. For this reason, it is recommended to always explicitly specify low-number port mappings as strings.
Port 21 is impacted by this, and quoting the port ensures that, should someone translate this to a docker-compose file, this behaviour won't arise. As such, the 21:21 is quoted in the various examples in the readme file.
Moreover, I have translated the first usage example into a compose file and placed a note there as well.